feat: adds landing page scaffolding #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for lbgg pending review.Visit the deploys page to approve it
|
Eein
force-pushed
the
feat/add-landing-page-scaffolding
branch
3 times, most recently
from
0689bd1 to
100ef47
Compare
TheTedder
reviewed
Oct 31, 2024
TheTedder
reviewed
Nov 2, 2024
chore: adds tests
chore: undo unneeded shared interface chore: remove old todo chore: add test to LandingLeaderboards
chore: remove unused code chore: remove unused code
Eein
force-pushed
the
feat/add-landing-page-scaffolding
branch
from
1362a4d to
6db44a0
Compare
Closed
|
Rebased, and made the changes requested - Removed the mocks completely since this isn't doing any integration tests - more or less copy pasted from elsewhere which is why it was the way it is. |
TheTedder
approved these changes
Nov 4, 2024
buffet-time
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the landing page scaffolding for games list and the side about panel.
Have a couple of common test cases to verify rendering doesn't look weird.
These components can likely be more atomic, but would make more sense when styling.
Since intitial commit:
tailwind.config.js- this is currently set to override, as the design team may want something else down the road. they are named very specifically as to not override the existing colorsRemaining Work
Link to Issue
Tangentially related to #639
Acceptance
Simple "should render" tests are provided
Steps for testing
Should render.
Images